[GitHub] [flink] HuangZhenQiu commented on issue #9689: [FLINK-7151] add a basic function ddl

2019-12-07 Thread GitBox
HuangZhenQiu commented on issue #9689: [FLINK-7151] add a basic function ddl URL: https://github.com/apache/flink/pull/9689#issuecomment-562914670 This PR is split into multiple smaller PRs. It is no longer needed. This is an

[GitHub] [flink] HuangZhenQiu commented on issue #9689: [FLINK-7151] add a basic function ddl

2019-10-07 Thread GitBox
HuangZhenQiu commented on issue #9689: [FLINK-7151] add a basic function ddl URL: https://github.com/apache/flink/pull/9689#issuecomment-539322429 @walterddr Thanks for the comments and suggestions. For the changing of CatalogFunctionImpl constructor, let's wait for @bowenli86 's feedba

[GitHub] [flink] HuangZhenQiu commented on issue #9689: [FLINK-7151] add a basic function ddl

2019-09-29 Thread GitBox
HuangZhenQiu commented on issue #9689: [FLINK-7151] add a basic function ddl URL: https://github.com/apache/flink/pull/9689#issuecomment-536370130 @bowenli86 @danny0405 @suez1224 Would you please review this PR? This is an

[GitHub] [flink] HuangZhenQiu commented on issue #9689: [FLINK-7151] add a basic function ddl

2019-09-27 Thread GitBox
HuangZhenQiu commented on issue #9689: [FLINK-7151] add a basic function ddl URL: https://github.com/apache/flink/pull/9689#issuecomment-536014545 @bowenli86 Thanks for pointing it out for more it test. I will create a CatalogFunctionITCase to test the function operations.

[GitHub] [flink] HuangZhenQiu commented on issue #9689: [FLINK-7151] add a basic function ddl

2019-09-18 Thread GitBox
HuangZhenQiu commented on issue #9689: [FLINK-7151] add a basic function ddl URL: https://github.com/apache/flink/pull/9689#issuecomment-532946316 @suez1224 @fhueske @danny0405 Would you please take a look the PR? This is an a