[GitHub] [flink] JingGe commented on pull request #18911: [FLINK-26357][format] add FLINK API annotations

2022-02-25 Thread GitBox
JingGe commented on pull request #18911: URL: https://github.com/apache/flink/pull/18911#issuecomment-1051114530 Thanks @fapaul for the feedback. Commit messages have been updated. Please help merging the PR. Many thanks! -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] JingGe commented on pull request #18911: [FLINK-26357][format] add FLINK API annotations

2022-02-25 Thread GitBox
JingGe commented on pull request #18911: URL: https://github.com/apache/flink/pull/18911#issuecomment-1050793640 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] JingGe commented on pull request #18911: [FLINK-26357][format] add FLINK API annotations

2022-02-25 Thread GitBox
JingGe commented on pull request #18911: URL: https://github.com/apache/flink/pull/18911#issuecomment-1050788912 > Thanks for the PR, @JingGe, I added some comments. In general, it looks fine to me, with the exception of two points: > > * What is the rationale behind marking the