[GitHub] [flink] JingsongLi commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-12-02 Thread GitBox
JingsongLi commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-984476208 @tsreaper can you rebase latest master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] JingsongLi commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-12-02 Thread GitBox
JingsongLi commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-984476008 Hi @StephanEwen , do you have other comments? We can merge this if everything right. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] JingsongLi commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-11-17 Thread GitBox
JingsongLi commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-972468104 Hi all, I'll give my understanding. (Correct me if I am wrong) ## Object ArrayList vs Lazy deserialization As long as the objects inside the `ArrayList` do not

[GitHub] [flink] JingsongLi commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-11-15 Thread GitBox
JingsongLi commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-969890963 @slinkydeveloper @JingGe @fapaul Do you have other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] JingsongLi commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-10-21 Thread GitBox
JingsongLi commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-948644481 @JingGe @slinkydeveloper Good suggestion, we should put the IO operation on the fetcher side. @tsreaper +1 to "we should never call the hasNext method if there is no more

[GitHub] [flink] JingsongLi commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-10-19 Thread GitBox
JingsongLi commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-947295434 Hi @slinkydeveloper @tsreaper , I think Avro and StreamFormat are in conflict conceptually. In the comments of StreamFormat: > Compared to the {@link BulkFormat}, the