subject:"\[GitHub\] \[flink\] KurtYoung commented on issue #10316\: \[FLINK\-14624\]\[table\-blink\] Support computed column as rowtime attribute"

[GitHub] [flink] KurtYoung commented on issue #10316: [FLINK-14624][table-blink] Support computed column as rowtime attribute

2019-12-05 Thread GitBox

KurtYoung commented on issue #10316: [FLINK-14624][table-blink] Support computed column as rowtime attribute URL: https://github.com/apache/flink/pull/10316#issuecomment-562400476 The watermark part LGTM This is an automated

[GitHub] [flink] KurtYoung commented on issue #10316: [FLINK-14624][table-blink] Support computed column as rowtime attribute

2019-12-04 Thread GitBox

KurtYoung commented on issue #10316: [FLINK-14624][table-blink] Support computed column as rowtime attribute URL: https://github.com/apache/flink/pull/10316#issuecomment-561947825 So IIUC `StreamExecWatermarkAssigner` only cares about the emit interval, right? Could we make this physical

[GitHub] [flink] KurtYoung commented on issue #10316: [FLINK-14624][table-blink] Support computed column as rowtime attribute

2019-12-02 Thread GitBox

KurtYoung commented on issue #10316: [FLINK-14624][table-blink] Support computed column as rowtime attribute URL: https://github.com/apache/flink/pull/10316#issuecomment-560961349 Please rebase and resolve conflicts, I will review this.