[GitHub] [flink] LadyForest commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-28 Thread via GitHub
LadyForest commented on code in PR #21717: URL: https://github.com/apache/flink/pull/21717#discussion_r1089690301 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ExecutorImpl.java: ## @@ -0,0 +1,447 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] LadyForest commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-27 Thread via GitHub
LadyForest commented on code in PR #21717: URL: https://github.com/apache/flink/pull/21717#discussion_r1089615342 ## flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/ExecutorImplITCase.java: ## @@ -414,50 +462,130 @@ void testStopJob()

[GitHub] [flink] LadyForest commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-23 Thread via GitHub
LadyForest commented on code in PR #21717: URL: https://github.com/apache/flink/pull/21717#discussion_r1083641565 ## flink-table/flink-sql-client/src/test/resources/sql/set.q: ## @@ -118,47 +118,61 @@ SELECT hive_add_one(1); Received a total of 1 row !ok -REMOVE JAR

[GitHub] [flink] LadyForest commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-23 Thread via GitHub
LadyForest commented on code in PR #21717: URL: https://github.com/apache/flink/pull/21717#discussion_r1083646639 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/utils/SqlGatewayServiceExtension.java: ## @@ -80,7 +81,8 @@ public void

[GitHub] [flink] LadyForest commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-19 Thread GitBox
LadyForest commented on code in PR #21717: URL: https://github.com/apache/flink/pull/21717#discussion_r1081032613 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/parser/SqlCommandParserImpl.java: ## @@ -18,35 +18,136 @@ package