LadyForest opened a new pull request, #22701:
URL: https://github.com/apache/flink/pull/22701

   ## What is the purpose of the change
   
   This PR fixes the incorrect test initialization for `NonDeterministicTests` 
which uses `streamTableEnv` to test batch behavior, which fails of course but 
has not been revealed due to the JUnit cannot recognize test ends with "Tests".
   
   
   ## Brief change log
   
   - Rename `NonDeterministicTests` to `NonDeterministicTest` to make CI 
recognize the test.
   - Fix the initialization way for `ExpressionTestBase` on how to init table 
env, which should be based on  streaming or batch mode.
   
   
   ## Verifying this change
   
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no**/ don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to