[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-30 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-931196086 Thanks again for the contribution @NickBurkard and many thanks for the review & merging it @zentol -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-29 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-930028688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-29 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-930040850 @zentol I've updated the release notes in https://issues.apache.org/jira/browse/FLINK-20845 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-29 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-930028688 @zentol My proposal would be to add migration remarks in the release notes, are you OK with that? -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-28 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-928956978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-28 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-929547478 I'm under the impression that from a Flink perspective, a user should update its POM file to point to Flink's 2.12 version instead of 2.11. Flink's Scala APIs

[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-28 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-928956978 I found two more minor references: https://github.com/apache/flink/blob/master/flink-end-to-end-tests/test-scripts/kafka-common.sh#L55 Also the flag at

[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-27 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-927847942 Thanks for the PR @NickBurkard I still saw some references to 2.11 * https://github.com/apache/flink/blame/master/docs/README.md#L113 *

[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-27 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-927836453 @NickBurkard I think the CI failed due to https://github.com/apache/flink/pull/17359 so it probably needs another rebase. -- This is an automated message from the

[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support

2021-09-24 Thread GitBox
MartijnVisser commented on pull request #14544: URL: https://github.com/apache/flink/pull/14544#issuecomment-926509165 @NickBurkard Thanks to your work for dropping the Scala Shell via https://github.com/apache/flink/pull/17340, does this now also unblock you to complete this PR? --