[GitHub] [flink] SteNicholas commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2022-01-17 Thread GitBox
SteNicholas commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-1015015059 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] SteNicholas commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2022-01-17 Thread GitBox
SteNicholas commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-1014648635 @wsry, I have added a commit for the failure of the CI. Please help to take a look at the update. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] SteNicholas commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2022-01-17 Thread GitBox
SteNicholas commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-1014246858 > The description for taskmanager.network.sort-shuffle.min-parallelism need also to be updated. @wsry , I would like to update the description for

[GitHub] [flink] SteNicholas commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-12-24 Thread GitBox
SteNicholas commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-1000826210 @hililiwei, thanks for your detailed review and I have addressed the above comment. IMO, the boolean type option has no the definition in NettyShuffleEnvironmentOptions

[GitHub] [flink] SteNicholas commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-12-02 Thread GitBox
SteNicholas commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-985186694 @hililiwei, thanks for your detailed review and I have addressed the above comment. IMO, the boolean type option has no the definition in `NettyShuffleEnvironmentOptions`

[GitHub] [flink] SteNicholas commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-11-17 Thread GitBox
SteNicholas commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-972457321 @wsry @zhuzhurk , could you please take a look at this pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on