aljoscha commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542688589 > > I don't think this will still work because this was not changed: > > https://github.com/apache/flink/blob/10f9f1d431dbf047ea14130d9fb7fdd4f78178fc/flink-connectors/flink-connector-elasticsearch6/src/main/resources/META-INF/services/org.apache.flink.table.factories.TableFactory#L16 > > > > . And you changed the name of the package. > > I have moved the file from `flink-connector-elasticsearch6` to `flink-sql-connector-elasticsearch6` just like what I did in the PR #9720 . So it should not be a problem? Yes, but for the other PR you changed the service file: https://github.com/apache/flink/blob/e2c4213a8f0664285658f25f2169487eb952909e/flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/services/org.apache.flink.table.factories.TableFactory#L16
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
