subject:"\[GitHub\] \[flink\] becketqin commented on a diff in pull request #23313\: \[FLINK\-20767\]\[table planner\] Support filter push down on nested fields"

[GitHub] [flink] becketqin commented on a diff in pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-09-20 Thread via GitHub

becketqin commented on code in PR #23313: URL: https://github.com/apache/flink/pull/23313#discussion_r1332312205 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java: ## @@ -1183,7 +1194,9 @@ private Map,

[GitHub] [flink] becketqin commented on a diff in pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-09-13 Thread via GitHub

becketqin commented on code in PR #23313: URL: https://github.com/apache/flink/pull/23313#discussion_r1324619744 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala: ## @@ -538,8 +550,34 @@ class