[GitHub] [flink] bowenli86 commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors

2019-07-19 Thread GitBox
bowenli86 commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors URL: https://github.com/apache/flink/pull/9172#issuecomment-513419017 > To clarify: > This = the builder created here. > That = the possible Hive

[GitHub] [flink] bowenli86 commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors

2019-07-19 Thread GitBox
bowenli86 commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors URL: https://github.com/apache/flink/pull/9172#issuecomment-513410194 > Keeping the name unchanged is fine to me. However, I don't expect that we will use

[GitHub] [flink] bowenli86 commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors

2019-07-19 Thread GitBox
bowenli86 commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors URL: https://github.com/apache/flink/pull/9172#issuecomment-513370872 re: 2, 3 > good idea. Will add re: 1 > I'm concerned about renaming since we don't

[GitHub] [flink] bowenli86 commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors

2019-07-18 Thread GitBox
bowenli86 commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors URL: https://github.com/apache/flink/pull/9172#issuecomment-513079203 cc @twalthr @xuefuz @lirui-apache @zjuwangg