[GitHub] [flink] buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module
buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module URL: https://github.com/apache/flink/pull/9843#issuecomment-542987335 @danny0405 @wuchong @dawidwys Thanks for you review! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module
buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module URL: https://github.com/apache/flink/pull/9843#issuecomment-541395902 @wucho @danny0 Thanks for your review and I've improve the code according to most of your comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module
buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module URL: https://github.com/apache/flink/pull/9843#issuecomment-541394973 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module
buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module URL: https://github.com/apache/flink/pull/9843#issuecomment-541276324 > As per the [code style guide](https://flink.apache.org/contributing/code-style-and-quality-java.html#java-optional), optionals should not be used for class fields. Thanks for pointing it out. Sorry I didn't notice that before. It's fixed now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module
buptljy commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module URL: https://github.com/apache/flink/pull/9843#issuecomment-541276393 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
