curcur commented on pull request #12525:
URL: https://github.com/apache/flink/pull/12525#issuecomment-646432766
> Thanks for updating the PR @curcur!
> Looks good to me.
Thank you so much @rkhachatryan for reviewing the PR :-) Appreciated !
curcur commented on pull request #12525:
URL: https://github.com/apache/flink/pull/12525#issuecomment-645153956
I've updated the existing unit test case
`StreamTaskTest.testCleanUpExceptionSuppressing`
to test the suppressed exception here, which I think it should be enough.
curcur commented on pull request #12525:
URL: https://github.com/apache/flink/pull/12525#issuecomment-643982040
I believe I have addressed most of the comments we have discussed on Friday
(not necessarily exactly the same way mentioned here, but roughly the idea).
There are two most