curcur commented on pull request #15200:
URL: https://github.com/apache/flink/pull/15200#issuecomment-862029755
Thanks @rkhachatryan !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
curcur commented on pull request #15200:
URL: https://github.com/apache/flink/pull/15200#issuecomment-862029547
I am fine as long as all the comments are addressed. Take a glance. approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
curcur commented on pull request #15200:
URL: https://github.com/apache/flink/pull/15200#issuecomment-856614747
For 6:
SET
SET_INTERNAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
curcur commented on pull request #15200:
URL: https://github.com/apache/flink/pull/15200#issuecomment-856614307
For 7:
This is what I mean
MapState
entries, keys, values;
keys = entries.getKeys();
values = entries.getValues();
keys.remove(some
curcur commented on pull request #15200:
URL: https://github.com/apache/flink/pull/15200#issuecomment-855628016
Thanks @rkhachatryan for addressing the comments!
Some remaining points to discuss offline
1. why "MERGE_NS" is named "stateMerged" instead of "mergeNamespaces"
2.
curcur commented on pull request #15200:
URL: https://github.com/apache/flink/pull/15200#issuecomment-810002177
Main issues:
1. Loader seems a bit too hacky, I am not sure whether we can use it this
way, need @pnowojski to take a look
2. Map iterators, have some uncertainties,
curcur commented on pull request #15200:
URL: https://github.com/apache/flink/pull/15200#issuecomment-803851674
I've done a pass. I've found `ChangelogAggregatingState` has not been
integrated with changelog yet?
I will do another pass on state
