curcur opened a new pull request #12769:
URL: https://github.com/apache/flink/pull/12769


   The right exception should be `org.apache.kafka.common.KafkaException` 
instead of `kafka.common.KafkaException`
   
   At least the "numTries" exception should be thrown instead of the binding 
exception.
   
   ## What is the purpose of the change
   
   Currently, binding exception is never caught in `KafkaTestEnvironmentImpl`, 
hence re-tries of different port allocation never happens.
   
   Use the right KafkaException in this fix.
   
   
   ## Brief change log
   catch `org.apache.kafka.common.KafkaException` instead of 
`kafka.common.KafkaException` when binding fails to enable retry logic.
   
   
   ## Verifying this change
   
   TBD
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to