[GitHub] [flink] dmvk commented on pull request #17159: [FLINK-24129][connectors-pulsar] Harden TopicRangeTest.rangeCreationH…

2021-09-16 Thread GitBox
dmvk commented on pull request #17159: URL: https://github.com/apache/flink/pull/17159#issuecomment-921280507 @XComp Thanks for the review, I've addressed your comments, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] dmvk commented on pull request #17159: [FLINK-24129][connectors-pulsar] Harden TopicRangeTest.rangeCreationH…

2021-09-07 Thread GitBox
dmvk commented on pull request #17159: URL: https://github.com/apache/flink/pull/17159#issuecomment-914168323 @XComp changed, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] dmvk commented on pull request #17159: [FLINK-24129][connectors-pulsar] Harden TopicRangeTest.rangeCreationH…

2021-09-07 Thread GitBox
dmvk commented on pull request #17159: URL: https://github.com/apache/flink/pull/17159#issuecomment-914163218 You're correct, there is no reason for having a repeated test with random input here, I was thinking about this as well. I'll change it, this is just too hard to understand