[GitHub] [flink] fsk119 commented on a diff in pull request #20822: [FLINK-25447][table-planner] Fix batch query cannot generate plan when a sorted view into multi sinks

2023-08-09 Thread via GitHub
fsk119 commented on code in PR #20822: URL: https://github.com/apache/flink/pull/20822#discussion_r1288206191 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdColumnUniquenessTest.scala: ## @@ -54,6 +60,45 @@ class

[GitHub] [flink] fsk119 commented on a diff in pull request #20822: [FLINK-25447][table-planner] Fix batch query cannot generate plan when a sorted view into multi sinks

2023-01-10 Thread GitBox
fsk119 commented on code in PR #20822: URL: https://github.com/apache/flink/pull/20822#discussion_r1066546132 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdDistribution.scala: ## @@ -87,6 +87,10 @@ class

[GitHub] [flink] fsk119 commented on a diff in pull request #20822: [FLINK-25447][table-planner] Fix batch query cannot generate plan when a sorted view into multi sinks

2023-01-05 Thread GitBox
fsk119 commented on code in PR #20822: URL: https://github.com/apache/flink/pull/20822#discussion_r1063197587 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/SortTest.scala: ## @@ -46,6 +46,134 @@ class SortTest extends