[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-21 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r753941893 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-21 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r753941893 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-16 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r750958184 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-16 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r750776396 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-16 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r750221628 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-16 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r750221628 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-15 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r749949235 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-15 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r749902979 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-15 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r749836477 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-15 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r749317372 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-15 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r749171434 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-15 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r749115508 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-14 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r748991806 ## File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java ## @@ -174,6

[GitHub] [flink] gaurav726 commented on a change in pull request #17754: [FLINK-24861][connector][jdbc] Fix false cache lookup for empty data

2021-11-14 Thread GitBox
gaurav726 commented on a change in pull request #17754: URL: https://github.com/apache/flink/pull/17754#discussion_r748991713 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java ## @@ -146,10