[GitHub] [flink] huwh commented on pull request #22137: [FLINK-31233][Rest] Return 404 when task manager stdout/log files not exist.

huwh commented on PR #22137: URL: https://github.com/apache/flink/pull/22137#issuecomment-1591105458 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] huwh commented on pull request #22137: [FLINK-31233][Rest] Return 404 when task manager stdout/log files not exist.

huwh commented on PR #22137: URL: https://github.com/apache/flink/pull/22137#issuecomment-1591025199 Thanks, unit tests have been fixed. `testStdoutFileHandlerHandleFileNotFoundException` failed because `TestingChannelHandlerContext#write` return an unfinished future. Since we

[GitHub] [flink] huwh commented on pull request #22137: [FLINK-31233][Rest] Return 404 when task manager stdout/log files not exist.

huwh commented on PR #22137: URL: https://github.com/apache/flink/pull/22137#issuecomment-1590802650 I changed the "handleException" to return a "CompletableFuture" so that we can pass the result of "HandlerUtils.sendResponse" to the AbstractHandler. PTAL -- This is an automated message

[GitHub] [flink] huwh commented on pull request #22137: [FLINK-31233][Rest] Return 404 when task manager stdout/log files not exist.

huwh commented on PR #22137: URL: https://github.com/apache/flink/pull/22137#issuecomment-1582429175 @KarmaGYZ, could you please help review this PR in your free time? thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to