imaffe commented on pull request #18014:
URL: https://github.com/apache/flink/pull/18014#issuecomment-1003372339
Sure, have a great vacation and happy new year everyone !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
imaffe commented on pull request #18014:
URL: https://github.com/apache/flink/pull/18014#issuecomment-1003253983
@fapaul Hi Paul, I've already rebased the branch~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
imaffe commented on pull request #18014:
URL: https://github.com/apache/flink/pull/18014#issuecomment-123030
> > @PatrickRen Updated ~
>
> @imaffe
>
> The text used in the old JUnit4 should be more like an error msg than
description before the test. It should be better to
imaffe commented on pull request #18014:
URL: https://github.com/apache/flink/pull/18014#issuecomment-998833972
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
imaffe commented on pull request #18014:
URL: https://github.com/apache/flink/pull/18014#issuecomment-997651179
@PatrickRen Updated ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
imaffe commented on pull request #18014:
URL: https://github.com/apache/flink/pull/18014#issuecomment-992065075
@JingGe Is there anything else we might missed ? I feel this PR is about
ready. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message,
imaffe commented on pull request #18014:
URL: https://github.com/apache/flink/pull/18014#issuecomment-989443748
@JingGe Updated ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
