[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1694921585 @Myasuka @fredia I have resolved all conversations? Could you have a look at this pr again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1581609186 > Hi @jiexray I wonder whether you would like to continue working on this PR or not Thank you for you reminding. I have resolved all converasation, and I will rebase my pr this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1520059668 > @jiexray Please click `Resolve converasation` button if you think you already addressed the comment. OK, I will re-check all converasation, and click `Resolve converasation`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1415322517 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1414118862 @roncohen Thank you for you comments. I have fixed some problems in the commit https://github.com/apache/flink/pull/21410/commits/944bf2a8fe21628d279df006fbc417934a122381. However, I am still confused about the problem related to `TestLoggerExtension`. I have replied it just after your comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1414028883 @Myasuka Thank you for your comments. I have fixed them in a new commit. https://github.com/apache/flink/pull/21410/commits/bf87b002395acf1c6d0a606f6699544087769bd7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1345145853 Hello @snuyanzin, I have fixed your comments with a new commit. The modifications includes: - Remove public statement from test function - Replace `ExceptionUtils.findThrowable` with `assertThatThrownBy` - Replace `TestLogger` in junit4 with `TestLoggerExtension` in junit5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1343908038 Thank you @snuyanzin for your comments, I will fix them as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1329208363 Hi, @piotrp @Myasuka Would you mind helping to check this flink-statebackend-changelog JUnit5 Migration ? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1329197680 Hello @PatrickRen @ruanhang1993, I am trying to migrate junit tests in flink-statebackend-changelog. Some base tests for changelog are in flink-runtime. The two base test classes are `StateBackendTestBase` and `StateBackendMigrationTestBase`. Could you help me to resolve the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
