[GitHub] [flink] kl0u commented on issue #9974: [FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from CommandLine

2019-10-31 Thread GitBox
kl0u commented on issue #9974: [FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from CommandLine URL: https://github.com/apache/flink/pull/9974#issuecomment-548516165 Merged. This is an automated

[GitHub] [flink] kl0u commented on issue #9974: [FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from CommandLine

2019-10-28 Thread GitBox
kl0u commented on issue #9974: [FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from CommandLine URL: https://github.com/apache/flink/pull/9974#issuecomment-547181779 Thanks for the review @TisonKun ! I integrated your comments, apart from the one for the

[GitHub] [flink] kl0u commented on issue #9974: [FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from CommandLine

2019-10-28 Thread GitBox
kl0u commented on issue #9974: [FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from CommandLine URL: https://github.com/apache/flink/pull/9974#issuecomment-546973226 @TisonKun let me know if you need any more input for the review of this PR, so that we can merge

[GitHub] [flink] kl0u commented on issue #9974: [FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from CommandLine

2019-10-28 Thread GitBox
kl0u commented on issue #9974: [FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from CommandLine URL: https://github.com/apache/flink/pull/9974#issuecomment-546876357 Hi @TisonKun ! Thanks for the comments, I integrated them. Now for your question, I understand