[GitHub] [flink] liming30 commented on a change in pull request #13109: [FLINK-18808][runtime/metrics] Include side outputs in numRecordsOut metric.

2020-08-27 Thread GitBox
liming30 commented on a change in pull request #13109: URL: https://github.com/apache/flink/pull/13109#discussion_r478836972 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/collector/selector/DirectedOutputsCollector.java ## @@ -0,0 +1,67 @@

[GitHub] [flink] liming30 commented on a change in pull request #13109: [FLINK-18808][runtime/metrics] Include side outputs in numRecordsOut metric.

2020-08-27 Thread GitBox
liming30 commented on a change in pull request #13109: URL: https://github.com/apache/flink/pull/13109#discussion_r478431177 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/collector/selector/SelectedOutputsCollectorImpl.java ## @@ -0,0 +1,61

[GitHub] [flink] liming30 commented on a change in pull request #13109: [FLINK-18808][runtime/metrics] Include side outputs in numRecordsOut metric.

2020-08-27 Thread GitBox
liming30 commented on a change in pull request #13109: URL: https://github.com/apache/flink/pull/13109#discussion_r478431177 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/collector/selector/SelectedOutputsCollectorImpl.java ## @@ -0,0 +1,61

[GitHub] [flink] liming30 commented on a change in pull request #13109: [FLINK-18808][runtime/metrics] Include side outputs in numRecordsOut metric.

2020-08-27 Thread GitBox
liming30 commented on a change in pull request #13109: URL: https://github.com/apache/flink/pull/13109#discussion_r478424895 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/collector/selector/SelectedOutputsCollectorImpl.java ## @@ -0,0 +1,62

[GitHub] [flink] liming30 commented on a change in pull request #13109: [FLINK-18808][runtime/metrics] Include side outputs in numRecordsOut metric.

2020-08-26 Thread GitBox
liming30 commented on a change in pull request #13109: URL: https://github.com/apache/flink/pull/13109#discussion_r477242251 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java ## @@ -739,40 +749,59 @@ public void

[GitHub] [flink] liming30 commented on a change in pull request #13109: [FLINK-18808][runtime/metrics] Include side outputs in numRecordsOut metric.

2020-08-26 Thread GitBox
liming30 commented on a change in pull request #13109: URL: https://github.com/apache/flink/pull/13109#discussion_r477237731 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java ## @@ -409,7 +410,7 @@ public OP

[GitHub] [flink] liming30 commented on a change in pull request #13109: [FLINK-18808][runtime/metrics] Include side outputs in numRecordsOut metric.

2020-08-26 Thread GitBox
liming30 commented on a change in pull request #13109: URL: https://github.com/apache/flink/pull/13109#discussion_r477235414 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/collector/selector/CopyingDirectedOutput.java ## @@ -36,31 +38,56 @@