[GitHub] [flink] lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data…

2019-08-12 Thread GitBox
lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data… URL: https://github.com/apache/flink/pull/9399#issuecomment-520307510 @bowenli86 Throwing `SqlExecutionException` is part of the contract of `Executor`, so in general I expect SQL

[GitHub] [flink] lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data…

2019-08-10 Thread GitBox
lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data… URL: https://github.com/apache/flink/pull/9399#issuecomment-520201929 @bowenli86 The test in `LocalExecutorITCase` is to verify `LocalExecutor` throws a proper exception (i.e.

[GitHub] [flink] lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data…

2019-08-09 Thread GitBox
lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data… URL: https://github.com/apache/flink/pull/9399#issuecomment-519797730 @bowenli86 PR updated according to your suggestions. Please take another look. Thanks.

[GitHub] [flink] lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data…

2019-08-08 Thread GitBox
lirui-apache commented on issue #9399: [FLINK-13526][sql-client] Switching to a non existing catalog or data… URL: https://github.com/apache/flink/pull/9399#issuecomment-519767241 @xuefuz @bowenli86 @zjuwangg please have a look. I suppose it's trivial change.