[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-14 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1166961006 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -766,13 +776,12 @@ private void returnExcessMemorySegments() {

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-14 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1166952794 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -766,13 +776,12 @@ private void returnExcessMemorySegments() {

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-13 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1165117526 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java: ## @@ -255,9 +253,38 @@ void testRecycleAfterDestroy() { void

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-13 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1165111871 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java: ## @@ -255,9 +253,38 @@ void testRecycleAfterDestroy() { void

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-13 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1165105388 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -766,13 +776,12 @@ private void returnExcessMemorySegments() {

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-12 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1164941748 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -49,7 +49,11 @@ * * The size of this pool can be dynamically

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-12 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1164959231 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -766,13 +776,12 @@ private void returnExcessMemorySegments() {

[GitHub] [flink] reswqa commented on a diff in pull request #22381: [FLINK-31763][runtime] Convert requested buffers to overdraft buffers when pool size is decreased

2023-04-12 Thread via GitHub
reswqa commented on code in PR #22381: URL: https://github.com/apache/flink/pull/22381#discussion_r1164944912 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -671,13 +675,20 @@ public void setNumBuffers(int numBuffers) {