senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-708418856
@dawidwys i did a bit of changes today i'll try and do more tomorrow if you
beat me to the punch so be it :)
i plugged in your changes but the tests are red and there
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-707626966
Hey @dawidwys I am really sorry was away all weekend and couldn't address
your issues... Also sorry about the silly issues here and there "my experience
in Java is measured in
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-703233062
@dawidwys i took care of every single comment you mentioned hope that does
the deed.
This is an automated
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-703232999
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message,
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-702037986
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message,
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-701879609
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message,
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-701266601
@dawidwys Ohh .. i didn't know that ! anyway i just created a local branch
from master with the history and squash merged everything since i couldn't
rebase without merging
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-701257642
heemm .. maybe it's only in github enterprise then.
Okay then i'll try to rebase one more time .. if it takes too much time i'll
squash them.
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-701253493
In github there is the option "when the PR is approved" to squash merge the
changes instead of the normal merge. Usually the merge button has an arrow
beneath it that lets you
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-701216291
@dawidwys you mean only the last one ?
because i did that several times before
otherwise i would just reset the branch and cherry pick my commits again
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-701181655
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message,
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-700850674
Sure will do that right away :)
On Tue 29. Sep 2020 at 19:02, Dawid Wysakowicz
wrote:
>
>
> Sorry, unfortunately you are right that I forgot about it :(.
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-699868484
Hey guys did @austince or @dawidwys had any time to look at this ? it's
been so long in the making that i think you guys completely forgot about it !
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-685341691
@austince @dawidwys
Hey guys,
Finally got around doing the changes you suggested.
Now we do have a reset message "that was obviously needed for some reason i
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-650738330
@dawidwys @austince Thanks for the "get well" wishes :) i am doing much
better now.
I finished some of the comments you guys addressed i also had some comments
/
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-648724664
sorry for the no update for the past week .. it's pollen season and i was
suffering from it a bit last weekend ... will do my best to finish that all
during the upcoming
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-644549028
awesome .. will look into the changes and hopefully be done by them next
weekend.
This is an automated
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-644117975
Hey @austince @dawidwys,
Did you guys had the time to look at the changes ? i really want to close
that PR to start working on some other stuff "limited free time
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-640193242
@dawidwys @austince no worries at all .. I've been having some computer
trouble as well lately my 7 year old laptop decided it was time ! lucky for me
that was an excuse for a
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-636692690
@austince and @dawidwys it seems there is an issue with azure can't rerun
the pipeline and when it ran on Saturday i couldn't find mvn in the e2e tests.
Please advise.
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-636502616
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message,
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-636442005
Hemm .. previous run of Travis failed in the e2e tests because it couldn't
find maven !
```
Invoking mvn with '/home/vsts/maven_cache/apache-maven-3.2.5/bin/mvn
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-636331412
Mr. @flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message,
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-634251720
Thanks a lot for the time and effort guys. Will review your suggestions on
Friday and do the required changes :)
On Tue 26. May 2020 at 17:24, Austin Cawley-Edwards <
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-631906626
@aljoscha @austince just a ping in case you missed my last comment
This is an automated message from the
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-629626940
Please Mr @flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-629626611
Okay i pushed some new changes and let me explain my endeavors for the last
3 hours !
### The Goal
* combine body / correlation id parsing one go
* conform with
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-628393200
Super thanks a lot for the clarification.
will rebase and do the changes over the weekend as i have a bit of a cold :(
senegalo commented on pull request #12056:
URL: https://github.com/apache/flink/pull/12056#issuecomment-626194323
Had some issues with some dependencies that was missing for random reasons
so i wasn’t able to run the tests locally. I fixed them now. Can you please Mr
@flinkbot run azure
29 matches
Mail list logo
