[GitHub] [flink] shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib
shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#issuecomment-495542544 @flinkbot approve all This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib
shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#issuecomment-495541432 @sunjincheng121 @c4e , I think it is OK to use parent as suffix. We already have `flink-test-utils-parent` module. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib
shaoxuan-wang commented on issue #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#issuecomment-494873716 Thanks for the contribution, @c4e. The entire design looks good to me. I have gone over all the comments. It seems most of them have been addressed. There is one major comment about the way to persist and reload the mode. I noticed that you have responded to the reviewers, while they have not yet confirmed if they are happy with your solution or not. In general I am +1 on this PR. Will merge it in the next 1-2 days if there is no further comments/concerns coming out. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
