[GitHub] [flink] shuiqiangchen commented on a change in pull request #12902: [FLINK-18415][python] Support TableResult#collect in the Python Table…

2020-10-14 Thread GitBox
shuiqiangchen commented on a change in pull request #12902: URL: https://github.com/apache/flink/pull/12902#discussion_r505124750 ## File path: flink-python/src/main/java/org/apache/flink/api/common/python/PythonBridgeUtils.java ## @@ -162,7 +171,42 @@ return

[GitHub] [flink] shuiqiangchen commented on a change in pull request #12902: [FLINK-18415][python] Support TableResult#collect in the Python Table…

2020-10-14 Thread GitBox
shuiqiangchen commented on a change in pull request #12902: URL: https://github.com/apache/flink/pull/12902#discussion_r505124256 ## File path: flink-python/src/main/java/org/apache/flink/api/common/python/PythonBridgeUtils.java ## @@ -162,7 +171,42 @@ return

[GitHub] [flink] shuiqiangchen commented on a change in pull request #12902: [FLINK-18415][python] Support TableResult#collect in the Python Table…

2020-09-17 Thread GitBox
shuiqiangchen commented on a change in pull request #12902: URL: https://github.com/apache/flink/pull/12902#discussion_r490092680 ## File path: flink-python/pyflink/table/tests/test_table_environment_api.py ## @@ -445,6 +446,46 @@ def test_to_retract_stream(self):