[GitHub] [flink] snuyanzin commented on pull request #23217: [FLINK-32866][Tests] Enable the TestLoggerExtension for all junit5 tests
snuyanzin commented on PR #23217: URL: https://github.com/apache/flink/pull/23217#issuecomment-1701883872 That's a good question I've never encountered an issue, however I remember @zentol always asked to exclude junit5 extention in poms for test-jar in case there are junit4 baed test-jar depending on this. May be @zentol has some more info about possible issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #23217: [FLINK-32866][Tests] Enable the TestLoggerExtension for all junit5 tests
snuyanzin commented on PR #23217: URL: https://github.com/apache/flink/pull/23217#issuecomment-1695037306 The thing I didn't get is that from one side there are downstream test dependencies which could depend on JUnit4. After that change it the extension will be bundled by default... Before we intentionally excluded it in poms Who does this PR solve this issur? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
