[GitHub] [flink] swuferhong commented on a diff in pull request #23412: [FLINK-33083] Properly apply ReadingMetadataSpec for a TableSourceScan

2023-09-14 Thread via GitHub
swuferhong commented on code in PR #23412: URL: https://github.com/apache/flink/pull/23412#discussion_r1325700289 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSourceSpec.java: ## @@ -95,29 +92,19 @@ private

[GitHub] [flink] swuferhong commented on a diff in pull request #23412: [FLINK-33083] Properly apply ReadingMetadataSpec for a TableSourceScan

2023-09-14 Thread via GitHub
swuferhong commented on code in PR #23412: URL: https://github.com/apache/flink/pull/23412#discussion_r1325700289 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSourceSpec.java: ## @@ -95,29 +92,19 @@ private

[GitHub] [flink] swuferhong commented on a diff in pull request #23412: [FLINK-33083] Properly apply ReadingMetadataSpec for a TableSourceScan

2023-09-13 Thread via GitHub
swuferhong commented on code in PR #23412: URL: https://github.com/apache/flink/pull/23412#discussion_r1325238554 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSourceSpec.java: ## @@ -95,29 +92,19 @@ private

[GitHub] [flink] swuferhong commented on a diff in pull request #23412: [FLINK-33083] Properly apply ReadingMetadataSpec for a TableSourceScan

2023-09-13 Thread via GitHub
swuferhong commented on code in PR #23412: URL: https://github.com/apache/flink/pull/23412#discussion_r1325320081 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSourceSpec.java: ## @@ -95,29 +92,19 @@ private

[GitHub] [flink] swuferhong commented on a diff in pull request #23412: [FLINK-33083] Properly apply ReadingMetadataSpec for a TableSourceScan

2023-09-13 Thread via GitHub
swuferhong commented on code in PR #23412: URL: https://github.com/apache/flink/pull/23412#discussion_r1325238554 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSourceSpec.java: ## @@ -95,29 +92,19 @@ private