syhily commented on pull request #17452:
URL: https://github.com/apache/flink/pull/17452#issuecomment-1040448384
> The PulsarSerializationSchema looks mostly good, great work. I left some
last minor cleanup comments.
You are right. Using a generic type of `PulsarMessage` is better
syhily commented on pull request #17452:
URL: https://github.com/apache/flink/pull/17452#issuecomment-1040448384
> The PulsarSerializationSchema looks mostly good, great work. I left some
last minor cleanup comments.
You are right. Using a generic type of `PulsarMessage` is better
syhily commented on pull request #17452:
URL: https://github.com/apache/flink/pull/17452#issuecomment-1039111204
> Looks mostly good I am only a bit skeptical about the flushing behavior +
the message delayer.
>
> One quick note: For Kafka, the pending transactions block the
syhily commented on pull request #17452:
URL: https://github.com/apache/flink/pull/17452#issuecomment-1030376275
> The only concern is my limited knowledge of Pulsar transactions. Maybe you
can clarify the following scenarios.
>
> The job opens a transaction and sends records, now
syhily commented on pull request #17452:
URL: https://github.com/apache/flink/pull/17452#issuecomment-1028443462
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
syhily commented on pull request #17452:
URL: https://github.com/apache/flink/pull/17452#issuecomment-1027998488
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
