[GitHub] [flink] tillrohrmann commented on a change in pull request #9833: [FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11

2019-10-04 Thread GitBox
tillrohrmann commented on a change in pull request #9833: 
[FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11
URL: https://github.com/apache/flink/pull/9833#discussion_r331467083
 
 

 ##
 File path: 
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
 ##
 @@ -171,6 +171,11 @@ under the License.



+   
+   
+   -nobootcp
 
 Review comment:
   Ok, thanks for the info. I assume this is ok to use then.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] tillrohrmann commented on a change in pull request #9833: [FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11

2019-10-02 Thread GitBox
tillrohrmann commented on a change in pull request #9833: 
[FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11
URL: https://github.com/apache/flink/pull/9833#discussion_r330580313
 
 

 ##
 File path: 
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
 ##
 @@ -171,6 +171,11 @@ under the License.



+   
+   
+   -nobootcp
 
 Review comment:
   Do you know what affects this flag has for Java 8?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] tillrohrmann commented on a change in pull request #9833: [FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11

2019-10-02 Thread GitBox
tillrohrmann commented on a change in pull request #9833: 
[FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11
URL: https://github.com/apache/flink/pull/9833#discussion_r330541171
 
 

 ##
 File path: 
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
 ##
 @@ -171,6 +171,11 @@ under the License.



+   
+   
+   -nobootcp
 
 Review comment:
   I guess it is not so easy to only activate this flag if Java 11 is used, 
right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services