[GitHub] [flink] wsry commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2022-01-17 Thread GitBox
wsry commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-1014332311 @SteNicholas Thanks for the update, changes LGTM. I will help to merge it after the CI passes. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] wsry commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2022-01-13 Thread GitBox
wsry commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-1011913056 The description for taskmanager.network.sort-shuffle.min-parallelism need also to be updated. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] wsry commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2022-01-12 Thread GitBox
wsry commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-1011848043 @SteNicholas Thanks for your contribution, I have left a small comment. BTW, could you please also update the corresponding document for blocking shuffle?

[GitHub] [flink] wsry commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-12-24 Thread GitBox
wsry commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-1000828829 Hi, thanks a lot for the PR and review. I will take look after finishing this discussion: https://lists.apache.org/thread/pt2b1f17x2l5rlvggwxs6m265lo4ly7p. -- This is an

[GitHub] [flink] wsry commented on pull request #17814: [FLINK-24899][runtime] Enable data compression for blocking shuffle by default

2021-11-26 Thread GitBox
wsry commented on pull request #17814: URL: https://github.com/apache/flink/pull/17814#issuecomment-979880416 Thanks for preparing this PR, I will take a look soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the