wsry opened a new pull request, #22155:
URL: https://github.com/apache/flink/pull/22155

   ## What is the purpose of the change
   
   Currently, the SortMergeResultPartition may allocate more network buffers 
than the guaranteed size of the LocalBufferPool. As a result, some result 
partitions may need to wait other result partitions to release the 
over-allocated network buffers to continue. However, the result partitions 
which have allocated more than guaranteed buffers relies on the processing of 
input data to trigger data spilling and buffer recycling. The input data 
further relies on batch reading buffers used by the 
SortMergeResultPartitionReadScheduler which may already taken by those blocked 
result partitions that are waiting for buffers. Then deadlock occurs. This 
patch fixes the deadlock issue by reserving the guaranteed buffers on 
initializing.
   
   ## Brief change log
   
     - Reserve the guaranteed buffers on initializing for 
SortMergeResultPartition.
   
   ## Verifying this change
   
   This change added tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to