[GitHub] [flink] xmarker commented on pull request #17465: [FLINK-24488][connectors/kafka] KafkaRecordSerializationSchemaBuilder does not forward timestamp

2021-10-25 Thread GitBox
xmarker commented on pull request #17465: URL: https://github.com/apache/flink/pull/17465#issuecomment-951501239 @fapaul OK,I squashed commits and pushed again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] xmarker commented on pull request #17465: [FLINK-24488][connectors/kafka] KafkaRecordSerializationSchemaBuilder does not forward timestamp

2021-10-23 Thread GitBox
xmarker commented on pull request #17465: URL: https://github.com/apache/flink/pull/17465#issuecomment-950160789 @fapaul I have debug KafkaSinkITCase on my computer , I found the failure cause was due to SinkWriter.timestamp() is a negative number, when kafka producer serialize the record

[GitHub] [flink] xmarker commented on pull request #17465: [FLINK-24488][connectors/kafka] KafkaRecordSerializationSchemaBuilder does not forward timestamp

2021-10-21 Thread GitBox
xmarker commented on pull request #17465: URL: https://github.com/apache/flink/pull/17465#issuecomment-948712106 @fapaul I have pushed with rebase , thinks for your review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] xmarker commented on pull request #17465: [FLINK-24488][connectors/kafka] KafkaRecordSerializationSchemaBuilder does not forward timestamp

2021-10-21 Thread GitBox
xmarker commented on pull request #17465: URL: https://github.com/apache/flink/pull/17465#issuecomment-948708235 > @xmarker can you rebase your changes on the latest master. Some tests seem to fail and I wonder if these instabilities are fixed on the latest master version. --