xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of
pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-541383212
> @xuyang1706 Thanks for updating the patch. the patch LGTM overall. I
created a PR with some minor improvements against
xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of
pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-541380802
> Thanks for the contribution @xuyang1706 and the reviews @becketqin .
Overall it looks good to me. I only left a minor
xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of
pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-541029806
> @xuyang1706 Thanks for updating the patch. I left a few more comments.
Most of them are minor. One major thing is I am not
xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of
pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-536274725
> @xuyang1706 Thanks for updating the patch. I left a few more comments. Can
you take a look?
Thanks, the comments in
xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of
pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-535402676
> Thanks for the follow up @xuyang1706 . Overall the changes looks good to
me. I left some minor comments. Also I notices
xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of
pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-533951861
> Hi @xuyang1706 thanks for update,
> I've left additional comments, please look they.
@ex00 , thanks for your
xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of
pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-533113614
> Thanks for the contribution @xuyang1706 and sorry for joining the
discussion late. Please see some of my comments. In
xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of
pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-533109547
> @xuyang1706 Thanks for the patch. I left some comments. In general it
would avoid class name collision. We may also want
xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of
pipeline's api
URL: https://github.com/apache/flink/pull/9184#issuecomment-530808471
> Hi @xuyang1706,
> thanks for your work, I've just left a few comments, please look it then
you will have time.
