[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-17 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-543551865 This PR go to wrong direction, closing it.

[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-17 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-543078937 @flinkbot run travis --

[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-16 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542773911 > > > I don't think this will still work because this was not changed: > > >

[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-16 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542673703 @aljoscha Thanks for reviewing. @twalthr and Jark have different opinions about

[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-16 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542670575 > I don't think this will still work because this was not changed: > > h

[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-16 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542554937 @flinkbot run travis --

[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-16 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542554867 Still failed because of the same Kafka relevant test failure. -

[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-15 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542473562 @flinkbot run travis --

[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-15 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542450959 @flinkbot run travis --

[GitHub] [flink] yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-15 Thread GitBox
yanghua commented on issue #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6 URL: https://github.com/apache/flink/pull/9906#issuecomment-542450889 I have reported the Kafka test issue on Travis. Trying to rebuild now.