[GitHub] [flink] yangjf2019 commented on a change in pull request #9532: [hotfix][docs] Fix the dependent version of the hive connector error .

2019-09-01 Thread GitBox
yangjf2019 commented on a change in pull request #9532: [hotfix][docs] Fix the 
dependent version of the hive connector error .
URL: https://github.com/apache/flink/pull/9532#discussion_r319818490
 
 

 ##
 File path: docs/dev/table/hive/index.md
 ##
 @@ -78,8 +78,8 @@ To integrate with Hive, users need the following 
dependencies in their project.
 
 
   org.apache.flink
-  flink-shaded-hadoop-2-uber-2.7.5-{{site.version}}
-  {{site.version}}
+  flink-shaded-hadoop-2-uber
+  2.7.5-7.0
 
 Review comment:
   Hi, @wuchong @zentol ,I compiled the latest code, however we do not find the 
maven dependency as follows. 
   `
 org.apache.flink
 flink-shaded-hadoop-2-uber
 2.6.5-1.10-SNAPSHOT
 provided
   
   `
   `
 org.apache.flink
 flink-hadoop-compatibility_1.10-SNAPSHOT
 1.10-SNAPSHOT
 provided
   `
   so I think this 
[PR](https://github.com/apache/flink/commit/614e9b73345c3ec09d55f75426968b7329c7953a)
 is problematic. Many users will ask why this maven dependency is not found.And 
I saw that 
[‘travis-ci’](https://travis-ci.org/apache/flink/builds/578111960?utm_source=github_status&utm_medium=notification)
 has failed to build. Why can it be merged into master?
   I have submitted a new [Pull 
Request](https://github.com/apache/flink/pull/9591), please take a look, thank 
you!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] yangjf2019 commented on a change in pull request #9532: [hotfix][docs] Fix the dependent version of the hive connector error .

2019-08-28 Thread GitBox
yangjf2019 commented on a change in pull request #9532: [hotfix][docs] Fix the 
dependent version of the hive connector error .
URL: https://github.com/apache/flink/pull/9532#discussion_r318848475
 
 

 ##
 File path: docs/dev/table/hive/index.md
 ##
 @@ -78,8 +78,8 @@ To integrate with Hive, users need the following 
dependencies in their project.
 
 
   org.apache.flink
-  flink-shaded-hadoop-2-uber-2.7.5-{{site.version}}
-  {{site.version}}
+  flink-shaded-hadoop-2-uber
+  2.7.5-7.0
 
 Review comment:
   Hi, @wuchong @zentol , Thank you very much ! Someone has committed for this 
[PR](https://github.com/apache/flink/commit/614e9b73345c3ec09d55f75426968b7329c7953a),Maybe
 i will closed .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] yangjf2019 commented on a change in pull request #9532: [hotfix][docs] Fix the dependent version of the hive connector error .

2019-08-26 Thread GitBox
yangjf2019 commented on a change in pull request #9532: [hotfix][docs] Fix the 
dependent version of the hive connector error .
URL: https://github.com/apache/flink/pull/9532#discussion_r317585205
 
 

 ##
 File path: docs/dev/table/hive/index.md
 ##
 @@ -78,8 +78,8 @@ To integrate with Hive, users need the following 
dependencies in their project.
 
 
   org.apache.flink
-  flink-shaded-hadoop-2-uber-2.7.5-{{site.version}}
-  {{site.version}}
+  flink-shaded-hadoop-2-uber
+  2.7.5-7.0
 
 Review comment:
   Thank you, but I don't quite understand what you mean. I want to add it to 
the "docs/_config.yml" file and use the version number as a variable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services