[GitHub] [flink] zentol commented on a change in pull request #9833: [FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11
zentol commented on a change in pull request #9833: [FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11 URL: https://github.com/apache/flink/pull/9833#discussion_r331444010 ## File path: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml ## @@ -171,6 +171,11 @@ under the License. + + + -nobootcp Review comment: Not really, what I do know is that we're using this argument for all Flink builds since 1.7 and haven't had a problem with it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #9833: [FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11
zentol commented on a change in pull request #9833: [FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11 URL: https://github.com/apache/flink/pull/9833#discussion_r330575826 ## File path: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml ## @@ -171,6 +171,11 @@ under the License. + + + -nobootcp Review comment: Actually, yes it would be tricky to make it java version dependent and future-proof. Ideally, we'd have it in by default (future-proof) and remove it for java 8, but that's kinda tricky. Removing things based on a profile only works in some cases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #9833: [FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11
zentol commented on a change in pull request #9833: [FLINK-14276][quickstarts] Scala quickstart compiles on JDK 11 URL: https://github.com/apache/flink/pull/9833#discussion_r330573933 ## File path: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml ## @@ -171,6 +171,11 @@ under the License. + + + -nobootcp Review comment: well we could add a profile that adds this flag, but it would be inconsistent with the main Flink pom. And given that this is required since Java 9 I think it's fine to have it always on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
