[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49:
URL:
https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1630724942
> > One question that comes to my mind now.. This will only work with a 1
server no? if we have a Clickhouse cluster with more than 1 server (that will
have a zookeeper envolved) will not work no?
> > if this is true, I think we should have a note on documentation
>
> I tried to work normally in cluster mode
>
> My steps are as follows 1.create ck table
>
> ```
> create table if not exists default.ck_flink_test_local on cluster
clicks_cluster
> (
> user_id Int32,
> message String
> )
> engine =
ReplicatedMergeTree('/clickhouse/tables/{shard}/ck_flink_test_local',
'{replica}')
> PRIMARY KEY (user_id)
>
>
>
>
> create table if not exists default.ck_flink_test on cluster clicks_cluster
> (
> user_id Int32,
> message String
> )
> engine = Distributed('clicks_cluster', 'default', 'ck_flink_test_local',
user_id);
> ```
>
> 2. in flink sql client
>
> ```
>
> CREATE TABLE ck_flink_test(
>user_id INTEGER,
> message String
> ) WITH (
> 'connector' = 'jdbc',
> 'url' = 'jdbc:clickhouse://xx:xx/default',
> 'table-name' = 'ck_flink_test',
> 'username’='xx',
> 'password’='xx'
> );
> ```
>
> 3. exec insert sql
>
> ```
> INSERT INTO ck_flink_test (user_id, message) VALUES
> (101, 'Hello');
> ```
>
> 4. thd data can be viewed on the ck client
>
> ```
> select * from ck_flink_test;
> ```
>
> 5.the flink sql client
>
>
@eskabetxe I guess you might have defined the table incorrectly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49:
URL:
https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1630722843
> > One question that comes to my mind now.. This will only work with a 1
server no? if we have a Clickhouse cluster with more than 1 server (that will
have a zookeeper envolved) will not work no?
> > if this is true, I think we should have a note on documentation
>
> I tried to work normally in cluster mode
>
> My steps are as follows 1.create ck table
>
> ```
> create table if not exists default.ck_flink_test_local on cluster
clicks_cluster
> (
> user_id Int32,
> message String
> )
> engine =
ReplicatedMergeTree('/clickhouse/tables/{shard}/ck_flink_test_local',
'{replica}')
> PRIMARY KEY (user_id)
>
>
>
>
> create table if not exists default.ck_flink_test on cluster clicks_cluster
> (
> user_id Int32,
> message String
> )
> engine = Distributed('clicks_cluster', 'default', 'ck_flink_test_local',
user_id);
> ```
>
> 2. in flink sql client
>
> ```
>
> CREATE TABLE ck_flink_test(
>user_id INTEGER,
> message String
> ) WITH (
> 'connector' = 'jdbc',
> 'url' = 'jdbc:clickhouse://xx:xx/default',
> 'table-name' = 'ck_flink_test',
> 'username’='xx',
> 'password’='xx'
> );
> ```
>
> 3. exec insert sql
>
> ```
> INSERT INTO ck_flink_test (user_id, message) VALUES
> (101, 'Hello');
> ```
>
> 4. thd data can be viewed on the ck client
>
> ```
> select * from ck_flink_test;
> ```
>
> 5.the flink sql client
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49:
URL:
https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1630721467
> One question that comes to my mind now.. This will only work with a 1
server no? if we have a Clickhouse cluster with more than 1 server (that will
have a zookeeper envolved) will not work no?
>
> if this is true, I think we should have a note on documentation
I tried to work normally in cluster mode
My steps are as follows
1.create ck table
```
create table if not exists default.ck_flink_test_local on cluster
clicks_cluster
(
user_id Int32,
message String
)
engine =
ReplicatedMergeTree('/clickhouse/tables/{shard}/ck_flink_test_local',
'{replica}')
PRIMARY KEY (user_id)
create table if not exists default.ck_flink_test on cluster clicks_cluster
(
user_id Int32,
message String
)
engine = Distributed('clicks_cluster', 'default', 'ck_flink_test_local',
user_id);
```
2. in flink sql client
```
CREATE TABLE ck_flink_test(
user_id INTEGER,
message String
) WITH (
'connector' = 'jdbc',
'url' = 'jdbc:clickhouse://xx:xx/default',
'table-name' = 'ck_flink_test',
'username’='xx',
'password’='xx'
);
```
3. exec insert sql
```
INSERT INTO ck_flink_test (user_id, message) VALUES
(101, 'Hello');
```
4. thd data can be viewed on the ck client
```
select * from ck_flink_test;
```
5.the flink sql client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1594502796 Can you provide more specific information, such as error messages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1592422341 What other tasks are needed for this PR to merge @MartijnVisser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1588427649 @MartijnVisser the pr is ready -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1580174935 > > What other tasks are needed for this PR to merge > > You will need to rebase, because there are a couple of merge commits when you merged `main` into your branch. Those merge commits prevent merging; by rebasing, those commits should not be needed anymore the pr is ready @MartijnVisser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1578935469 > how do you recognize that `rebase` has successfully completed? I tried to do it with your branch (`git rebase upstream/main`) and got a number of conflicts The problem should be solved, you can try again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1578933279 I have identified the problem and during the final step, I executed a push instead of a force push, which caused the git rebase to fall into a loop. Thank you for your guidance @MartijnVisser @snuyanzin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1577972673 > if you execute this command on your branch > > ``` > git log --pretty-oneline > ``` > > you'll se several merge remote-tracking commits like > > ``` > c9e316596dc29fe3cb60578f53dce3b2b7fa8c1a (HEAD, WenDing/jdbc-clickhouse) Merge remote-tracking branch 'origin/jdbc-clickhouse' into jdbc-clickhouse > 9098ce56b0d703cda0a1f24f69058b9ab15af556 [FLINK-32068]connector jdbc support clickhouse > 8f6eff4e98003d568da8e722c06167dd491d4b53 [FLINK-32068]connector jdbc support clickhouse > 79cc7987be514afd0580d377208c798ec04a9415 [FLINK-32068] jdbc support clickhouse > 210968dca5a1fb47cd3268fa130f0ff5e54f299c [FLINK-32068]connector jdbc support clickhouse > c49485360a58e12ce7aad13ee627dcecc74c891e [FLINK-32068] connector jdbc support clickhouse > 00c94f815e8fda71777a83d63bd1e14111bc5650 [FLINK-32068] connector jdbc support clickhouse > cd268a2111ecfd0602f4150d5b1cc44b99779456 [FLINK-32068] connector jdbc support clickhouse > 86b57b88c1ef46f7d768875762ae253eec97 [FLINK-32068] connector jdbc support clickhouse > b81bc533fb98da2e5a76bddb22a4da8a52fb411e [FLINK-32068]connector jdbc support clickhouse > 55f79f215456c0dbb5fdd3d99a8be6985be092ef [FLINK-32068]connector jdbc support clickhouse > 1ff9e70dfbeefaa2e92c11db36fcca3c27bf9b49 Merge remote-tracking branch 'origin/jdbc-clickhouse' into jdbc-clickhouse > b6663a5fced2e4703c263827ca67c2dbacbf96bd [FLINK-32068]connector jdbc support clickhouse > 2655b6badefbea699ddb2465803076ec229b884b Merge remote-tracking branch 'origin/main' into jdbc-clickhouse > 9abdfafac76b17dcce371239ff5e16d9b90b9980 Merge branch 'main' into jdbc-clickhouse > d67de5f0f94b1de912470028ea1fc74376bd64b8 [FLINK-31551] Add support for CrateDB (#29) > 7b8617e03048d32d44dc453bd556d9f59d58a3e1 [FLINK-32068]connector jdbc support clickhouse,delete testcontainers version > bced473fbb8a606dca287fcf9329c7f052b9c4be Merge remote-tracking branch 'upstream/main' into jdbc-clickhouse > ``` > > and this the issue What else do I need to do? I executed it 1.Run git fetch upstream 2.Run git rebase upstream/main and complete this until the rebase has successfully completed 3.Force push your changes to your branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1577935401 > > Now this has always been resolved > > Unfortunately it hasn't been resolved. In case you want to rebase, what you should do is the following (this is assuming that you've added this repository as a remote called `upstream`.) > > 1. Run `git fetch upstream` > 2. Run `git rebase upstream/main` and complete this until the rebase has successfully completed > 3. Force push your changes to your branch It seems like this, my local submit history, the new feature started working after [Flink-31551] https://github.com/apache/flink-connector-jdbc/assets/19184146/0e983af8-e2ce-4178-b17a-7bb6032b8eb1;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1577102594 > Sorry i was late here, thanks for your PR @WenDing-Y The thing that I do not understand... why do we need 2 `ClickhouseDialect` classes > > ``` > flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java > flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialect.java > ``` > > and 2 `ClickhouseDialectFactory` > > ``` > flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectFactory.java > flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialectFactory.java > ``` Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1577098449 > > Ok, I have rebase @MartijnVisser > > I don't think you have, given that there are 4 merge-commits in this PR which shouldn't be there when rebased properly: [bb13e1f](https://github.com/apache/flink-connector-jdbc/commit/bb13e1f51d071c5180ccf7d658839a3afac61468) [bced473](https://github.com/apache/flink-connector-jdbc/commit/bced473fbb8a606dca287fcf9329c7f052b9c4be) [9abdfaf](https://github.com/apache/flink-connector-jdbc/commit/9abdfafac76b17dcce371239ff5e16d9b90b9980) [2655b6b](https://github.com/apache/flink-connector-jdbc/commit/2655b6badefbea699ddb2465803076ec229b884b) Sorry, it's my problem. I have rebase it again @MartijnVisser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1577063078 > Sorry i was late here, thanks for your PR @WenDing-Y The thing that I do not understand... why do we need 2 `ClickhouseDialect` classes > > ``` > flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialect.java > flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialect.java > ``` > > and 2 `ClickhouseDialectFactory` > > ``` > flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/clickhouse/dialect/ClickHouseDialectFactory.java > flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/clickhouse/ClickhouseDialectFactory.java > ``` Sorry, there was a slight error in my rebase just now, which caused this to happen. Now this has always been resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1577060660 > > Ok, I have rebase @MartijnVisser > > I don't think you have, given that there are 4 merge-commits in this PR which shouldn't be there when rebased properly: [bb13e1f](https://github.com/apache/flink-connector-jdbc/commit/bb13e1f51d071c5180ccf7d658839a3afac61468) [bced473](https://github.com/apache/flink-connector-jdbc/commit/bced473fbb8a606dca287fcf9329c7f052b9c4be) [9abdfaf](https://github.com/apache/flink-connector-jdbc/commit/9abdfafac76b17dcce371239ff5e16d9b90b9980) [2655b6b](https://github.com/apache/flink-connector-jdbc/commit/2655b6badefbea699ddb2465803076ec229b884b) > > What other tasks are needed for this PR to merge > > You will need to rebase, because there are a couple of merge commits when you merged `main` into your branch. Those merge commits prevent merging; by rebasing, those commits should not be needed anymore Sorry, it's my problem. I have rebase it again @MartijnVisser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1573107357 What other tasks are needed for this PR to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1570248521 compile_and_test (1.18-SNAPSHOT) fail, It doesn't seem like the problem was caused by my submission -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1567061806 Please help me review, thank you very much @snuyanzin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1562933275 the pr is ready -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1561651398 Okay, I have rebased, but I found that there were quite a few modifications in the testing section. I have already submitted some code, but the unit test cannot pass now. I am still modifying this section. @MartijnVisser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
