[GitHub] [flink-connector-jdbc] snuyanzin commented on pull request #29: [FLINK-31551] Add support for CrateDB

snuyanzin commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1573890436 thanks for the contribution @matriv thanks for the review @libenchao , @eskabetxe i'm about to merge it this weekend -- This is an automated message from the

[GitHub] [flink-connector-jdbc] snuyanzin commented on pull request #29: [FLINK-31551] Add support for CrateDB

snuyanzin commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1570287422 Thanks for addressing comments it looks ok from my side Thanks for review @eskabetxe @libenchao, please add anything if you have something not covered -- This is

[GitHub] [flink-connector-jdbc] snuyanzin commented on pull request #29: [FLINK-31551] Add support for CrateDB

snuyanzin commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1561356070 looks like different jna versions do not pass convergence check this command fails locally ``` mvn clean install -DskipTests -Dflink.convergence.phase=install