[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #617: [FLINK-32271] Report RECOMMENDED_PARALLELISM as an autoscaler metric V2

2023-06-12 Thread via GitHub
morhidi commented on code in PR #617: URL: https://github.com/apache/flink-kubernetes-operator/pull/617#discussion_r1226911859 ## flink-kubernetes-operator-autoscaler/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/RecommendedParallelismTest.java: ## @@ -0,0

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #617: [FLINK-32271] Report RECOMMENDED_PARALLELISM as an autoscaler metric V2

2023-06-09 Thread via GitHub
morhidi commented on code in PR #617: URL: https://github.com/apache/flink-kubernetes-operator/pull/617#discussion_r1224596698 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricEvaluator.java: ## @@ -137,12

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #617: [FLINK-32271] Report RECOMMENDED_PARALLELISM as an autoscaler metric V2

2023-06-09 Thread via GitHub
morhidi commented on code in PR #617: URL: https://github.com/apache/flink-kubernetes-operator/pull/617#discussion_r1224596436 ## flink-kubernetes-operator-autoscaler/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/RecommendedParallelismTest.java: ## @@ -0,0

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #617: [FLINK-32271] Report RECOMMENDED_PARALLELISM as an autoscaler metric V2

2023-06-09 Thread via GitHub
morhidi commented on code in PR #617: URL: https://github.com/apache/flink-kubernetes-operator/pull/617#discussion_r1224460888 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java: ## @@ -101,6 +100,7

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #617: [FLINK-32271] Report RECOMMENDED_PARALLELISM as an autoscaler metric V2

2023-06-09 Thread via GitHub
morhidi commented on code in PR #617: URL: https://github.com/apache/flink-kubernetes-operator/pull/617#discussion_r1223997743 ## flink-kubernetes-operator-autoscaler/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/RecommendedParallelismTest.java: ## @@ -0,0

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #617: [FLINK-32271] Report RECOMMENDED_PARALLELISM as an autoscaler metric V2

2023-06-09 Thread via GitHub
morhidi commented on code in PR #617: URL: https://github.com/apache/flink-kubernetes-operator/pull/617#discussion_r1223995845 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java: ## @@ -102,10 +108,8 @@