[GitHub] [flink-ml] lindong28 commented on pull request #66: [FLINK-26263] (followup) Check data size in LogisticRegression

2022-02-24 Thread GitBox
lindong28 commented on pull request #66: URL: https://github.com/apache/flink-ml/pull/66#issuecomment-1050616922 Thanks for the update! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-ml] lindong28 commented on pull request #66: [FLINK-26263] (followup) Check data size in LogisticRegression

2022-02-24 Thread GitBox
lindong28 commented on pull request #66: URL: https://github.com/apache/flink-ml/pull/66#issuecomment-1050611807 @zhipeng93 It is generally preferred to have a test to reproduce this bug with high likelihood, or be able to reproduce this bug manually. This is generally done on a

[GitHub] [flink-ml] lindong28 commented on pull request #66: [FLINK-26263] (followup) Check data size in LogisticRegression

2022-02-24 Thread GitBox
lindong28 commented on pull request #66: URL: https://github.com/apache/flink-ml/pull/66#issuecomment-1049850814 Thanks for PR! Could you confirm that the flaky test could be reproduced before this patch but not after this patch? And could you update the AllReduceImpl's Java