[GitHub] [flink-ml] zhipeng93 commented on a change in pull request #10: [FLINK-24354][FLIP-174] Improve the WithParams interface

zhipeng93 commented on a change in pull request #10: URL: https://github.com/apache/flink-ml/pull/10#discussion_r745361122 ## File path: pom.xml ## @@ -53,11 +53,8 @@ under the License. flink-ml-api -flink-ml-lib Review comment: We should probably add

[GitHub] [flink-ml] zhipeng93 commented on a change in pull request #10: [FLINK-24354][FLIP-174] Improve the WithParams interface

zhipeng93 commented on a change in pull request #10: URL: https://github.com/apache/flink-ml/pull/10#discussion_r744354063 ## File path: flink-ml-api/src/main/java/org/apache/flink/ml/param/Param.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] zhipeng93 commented on a change in pull request #10: [FLINK-24354][FLIP-174] Improve the WithParams interface

zhipeng93 commented on a change in pull request #10: URL: https://github.com/apache/flink-ml/pull/10#discussion_r744213344 ## File path: flink-ml-api/src/main/java/org/apache/flink/ml/param/ParamValidators.java ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] zhipeng93 commented on a change in pull request #10: [FLINK-24354][FLIP-174] Improve the WithParams interface

zhipeng93 commented on a change in pull request #10: URL: https://github.com/apache/flink-ml/pull/10#discussion_r744213263 ## File path: flink-ml-api/src/main/java/org/apache/flink/ml/param/Param.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] zhipeng93 commented on a change in pull request #10: [FLINK-24354][FLIP-174] Improve the WithParams interface

zhipeng93 commented on a change in pull request #10: URL: https://github.com/apache/flink-ml/pull/10#discussion_r742764716 ## File path: flink-ml-api/pom.xml ## @@ -38,6 +38,34 @@ under the License. ${flink.version} provided + + + org.apache.flink