[GitHub] [flink-statefun] slinkydeveloper edited a comment on pull request #110: [FLINK-17611] Unix domain socket connection between worker and function

2020-05-18 Thread GitBox
slinkydeveloper edited a comment on pull request #110: URL: https://github.com/apache/flink-statefun/pull/110#issuecomment-630606294 > would you like me to complete this over my branch or would you like to continue working on that? I think it's more practical if you continue to work

[GitHub] [flink-statefun] slinkydeveloper edited a comment on pull request #110: [FLINK-17611] Unix domain socket connection between worker and function

2020-05-15 Thread GitBox
slinkydeveloper edited a comment on pull request #110: URL: https://github.com/apache/flink-statefun/pull/110#issuecomment-629200528 > One thing I would recommend doing before merging is to manually verify the change by modifying statefun-python-greeter-example to connect over the unix dom

[GitHub] [flink-statefun] slinkydeveloper edited a comment on pull request #110: [FLINK-17611] Unix domain socket connection between worker and function

2020-05-15 Thread GitBox
slinkydeveloper edited a comment on pull request #110: URL: https://github.com/apache/flink-statefun/pull/110#issuecomment-629088572 @sjwiesman junixsocket is apache 2 https://github.com/kohlschutter/junixsocket/blob/master/LICENSE what should i write on the NOTICE? I didn't "copied