[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1117933738 ## docs/content/docs/how-to/creating-tables.md: ## @@ -114,6 +114,126 @@ Partition keys must be a subset of primary keys if primary keys are defined. By

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1117933424 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java: ## @@ -474,6 +474,20 @@ public class CoreOptions implements

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1117933201 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -123,6 +123,40 @@ public TableSchema

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1117933201 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -123,6 +123,40 @@ public TableSchema

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1112631890 ## docs/content/docs/how-to/creating-tables.md: ## @@ -114,6 +114,79 @@ Partition keys must be a subset of primary keys if primary keys are defined. By

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1112563412 ## flink-table-store-connector/pom.xml: ## @@ -151,6 +151,27 @@ under the License. provided + +

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1112563022 ## docs/content/docs/how-to/creating-tables.md: ## @@ -114,6 +114,79 @@ Partition keys must be a subset of primary keys if primary keys are defined. By

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r831443 ## docs/content/docs/how-to/creating-tables.md: ## @@ -114,6 +114,78 @@ Partition keys must be a subset of primary keys if primary keys are defined. By

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r831443 ## docs/content/docs/how-to/creating-tables.md: ## @@ -114,6 +114,78 @@ Partition keys must be a subset of primary keys if primary keys are defined. By

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r378285 ## docs/content/docs/how-to/creating-tables.md: ## @@ -114,6 +114,78 @@ Partition keys must be a subset of primary keys if primary keys are defined. By

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

SteNicholas commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r378087 ## docs/content/docs/how-to/creating-tables.md: ## @@ -114,6 +114,78 @@ Partition keys must be a subset of primary keys if primary keys are defined. By