shenzhu commented on pull request #24:
URL: https://github.com/apache/flink-table-store/pull/24#issuecomment-1050550061
Hey @tsreaper , I updated this PR and added some tests, would you mind
taking a look again when you have a moment? Thanks!
--
This is an automated message from the
shenzhu commented on pull request #24:
URL: https://github.com/apache/flink-table-store/pull/24#issuecomment-1049587025
> Hi @shenzhu .
>
> After a second thought, I believe we should still stick to your current
implementation with a small change. There are several reasons:
>
shenzhu commented on pull request #24:
URL: https://github.com/apache/flink-table-store/pull/24#issuecomment-1049484761
>
Hey @tsreaper , thanks for your feedback! I think that's a good point
I'm still new to this code base, please correct me if I didn't understand it
shenzhu commented on pull request #24:
URL: https://github.com/apache/flink-table-store/pull/24#issuecomment-1049044060
> BTW, can you add test for this?
Sure, thanks for your review! I will work on that
--
This is an automated message from the Apache Git Service.
To respond to
