[GitHub] [flink-web] echauchot commented on pull request #643: Add blog article: Howto test a batch source with the new Source framework
echauchot commented on PR #643: URL: https://github.com/apache/flink-web/pull/643#issuecomment-1545554335 @zentol Thanks for your review (once again). I addressed all your comments PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-web] echauchot commented on pull request #643: Add blog article: Howto test a batch source with the new Source framework
echauchot commented on PR #643: URL: https://github.com/apache/flink-web/pull/643#issuecomment-1545544022 > > I took a quick look over it. I feel especially for the IT case it would be nice to first provide an overview over the differnet parts that make up a test "There's a test framework; We need a backend the source can read from, a test context for Flinks testing framework to interact with the backend, ..." and then drill down into the details as you already did. > > Right now it's very "I have to do this and this and this" but you don't really know where you're heading. > > Totally agree, I'll do something similar to what I did on the source creation blog: an architecture paragraph done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-web] echauchot commented on pull request #643: Add blog article: Howto test a batch source with the new Source framework
echauchot commented on PR #643: URL: https://github.com/apache/flink-web/pull/643#issuecomment-1545283430 > I took a quick look over it. I feel especially for the IT case it would be nice to first provide an overview over the differnet parts that make up a test "There's a test framework; We need a backend the source can read from, a test context for Flinks testing framework to interact with the backend, ..." and then drill down into the details as you already did. > > Right now it's very "I have to do this and this and this" but you don't really know where you're heading. Totally agree, thanks for the suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-web] echauchot commented on pull request #643: Add blog article: Howto test a batch source with the new Source framework
echauchot commented on PR #643: URL: https://github.com/apache/flink-web/pull/643#issuecomment-1534918324 @MartijnVisser @zentol did almost all my last reviews. Would you have time to review this small article as you know the source framework ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
