dawidwys commented on a change in pull request #7077: [FLINK-10736][E2E tests]
Use already uploaded to s3 file in shaded s3 e2e tests
URL: https://github.com/apache/flink/pull/7077#discussion_r233352507
##########
File path: flink-end-to-end-tests/test-scripts/test_shaded_hadoop_s3a.sh
##########
@@ -22,15 +22,11 @@
source "$(dirname "$0")"/common.sh
source "$(dirname "$0")"/common_s3.sh
-s3_put $TEST_INFRA_DIR/test-data/words $ARTIFACTS_AWS_BUCKET
flink-end-to-end-test-shaded-s3a
-# make sure we delete the file at the end
-function shaded_s3a_cleanup {
- s3_delete $ARTIFACTS_AWS_BUCKET flink-end-to-end-test-shaded-s3a
-}
-trap shaded_s3a_cleanup EXIT
-
start_cluster
+bucket=flink-e2e-tests
Review comment:
Could we move the definition of `bucket` to `common_s3.sh`? Also I think we
should use uppercase here to follow the convention of constants like:
`TEST_INFRA_DIR`, `ARTIFACTS_AWS_BUCKET` etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
