[GitHub] dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common
dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#issuecomment-468511247 @sunjincheng121 Thanks a lot for the review. I will rebase the PR after all the commits of FLINK-11449 merged. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common
dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#issuecomment-468145920 @bowenli86 Thanks a lot for the suggestions. I'm fine to remove the annotation of ExternalCatalog and ExternalCatalogTable if they will be replaced with new Catalog API as these classes may be refactored or removed at that time. Regarding to the annotation itself, I think it's needed regardless whether it exists before. Porting classes is a good opportunity to correct the annotation which may be not marked correctly before. @twalthr What's your thought? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common
dianfu commented on issue #7848: [FLINK-10755][table] Port external catalogs in Table API extension points to flink-table-common URL: https://github.com/apache/flink/pull/7848#issuecomment-467855706 @twalthr Have created a PR to port external catalogs to flink-table-common. Could you help to take a look when it's convenient for you? Thanks in advance. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
